Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions lib/rules/require-emit-validator.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const utils = require('../utils')
/**
* @typedef {import('../utils').ComponentArrayEmit} ComponentArrayEmit
* @typedef {import('../utils').ComponentObjectEmit} ComponentObjectEmit
* @typedef {import('../utils').ComponentTypeEmit} ComponentTypeEmit
*/

// ------------------------------------------------------------------------------
Expand Down Expand Up @@ -83,8 +84,20 @@ module.exports = {
// Public
// ----------------------------------------------------------------------

return utils.executeOnVue(context, (obj) => {
utils.getComponentEmits(obj).forEach(checker)
})
return utils.compositingVisitors(
utils.executeOnVue(context, (obj) => {
utils.getComponentEmits(obj).forEach(checker)
}),
utils.defineScriptSetupVisitor(context, {
onDefineEmitsEnter(_node, emits) {
for (const emit of emits) {
if (emit.type === 'type') {
continue
}
checker(emit)
}
}
})
)
}
}
54 changes: 54 additions & 0 deletions tests/lib/rules/require-emit-validator.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,20 @@ ruleTester.run('require-emit-validator', rule, {
}
`,
parserOptions: { ecmaVersion: 6, sourceType: 'module' }
},
{
filename: 'test.vue',
code: `
<script setup lang="ts">
const emit = defineEmits<(e: 'foo')=>void>()
</script>
`,
parser: require.resolve('vue-eslint-parser'),
parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
parser: require.resolve('@typescript-eslint/parser')
}
}
],

Expand Down Expand Up @@ -325,6 +339,46 @@ ruleTester.run('require-emit-validator', rule, {
line: 4
}
]
},
{
filename: 'test.vue',
code: `
<script setup>
const emit = defineEmits(['foo'])
</script>
`,
parser: require.resolve('vue-eslint-parser'),
parserOptions: {
ecmaVersion: 6,
sourceType: 'module'
},
errors: [
{
messageId: 'missing',
data: { name: 'foo' },
line: 3
}
]
},
{
filename: 'test.vue',
code: `
<script setup>
const emit = defineEmits({foo:null})
</script>
`,
parser: require.resolve('vue-eslint-parser'),
parserOptions: {
ecmaVersion: 6,
sourceType: 'module'
},
errors: [
{
messageId: 'skipped',
data: { name: 'foo' },
line: 3
}
]
}
]
})