Vue 3 vueschool links #964
Conversation
There was a problem hiding this comment.
Hey @rahaug. Thanks for the PR! I've left a few comments regarding some of the lesson submitted.
As a whole, I have a general concern about the lessons generally requiring the user to have knowledge established in previous lessons.
For example, "Remember how we did XYZ in the last lesson?" While I'm able to figure out what's going on due to my experience, this seems like it could be confusing for new students trying to learn a concept when they won't have prior knowledge of what's going on.
Because the videos are placed so high on the individual docs page, we need to have the lessons provide a more holistic depiction of concepts since there's no guarantee that they will return back to the docs.
Let me know if you have any questions!
| @@ -1,5 +1,7 @@ | |||
| # Event Handling | |||
|
|
|||
| <VideoLesson href="https://vueschool.io/lessons/user-events-in-vue-3?friend=vuejs" title="Learn how to handle events on Vue School">Learn how to handle events in a free Vue School lesson</VideoLesson> | |||
There was a problem hiding this comment.
The lesson doesn't start in on the event material till halfway through. Not sure this is a good way to introduce people to a concept.
| @@ -1,5 +1,7 @@ | |||
| # Data Properties and Methods | |||
|
|
|||
| <VideoLesson href="https://vueschool.io/lessons/methods-in-vue-3?friend=vuejs" title="Learn how to use methods on Vue School">Learn how to work with data and methods with a free Vue School lesson</VideoLesson> | |||
There was a problem hiding this comment.
Because this section covers both data and methods, it seems misleading to have this lesson here at the top of the doc.
|
Hi @bencodezen, thanks for the detailed review and helpful feedback! I appreciate that you take the time to thoroughly review our content and help us create better content for the community and the documentation. We will work on the feedback and let you know. |
|
Hi @bencodezen, Thanks again for your time and contribution to the course. We have updated and re-recorded the lessons according to your feedback here and in the private messages. Can you please review the changes and merge if everything looks good? |
|
I've updated the PR and linked the video on how to install Vue Devtools, which also cover how to use devtools with local .HTML files as we've extracted that to an individual lesson. |
|
Hey @skirtles-code! Could I get your eyes on the new videos to see if I missed anything? |
There was a problem hiding this comment.
Would it be possible to get closed captions on the videos?
I've made a few observations about individual videos below. I don't have a good sense of how difficult it is to make minor changes to these videos so I've reviewed them just as I would for text documentation.
|
Thanks for reviewing the lessons @skirtles-code and good job with catching some things we've missed! We're happy to work with you to improve the lessons. Great suggestion on the captions! We have captions on all of our videos. Captions for these lessons are in production and will be available next week :) The video production is a bit complex, and it's not always straightforward to ımplement changes. Ben has been involved in the review process with the text versions, and we'd love to include you in the text-based reviews if you're interested before we record other lessons for the docs. We can patch in some of the suggestions. However, I do suggest merging now while we implement the changes, as the lessons are valuable to the docs users at this point. How does this sound? :) @danielkellyio can you please address the individual lesson's questions below? |
|
@skirtles-code thanks for taking the time to look over this and for the feedback! I've addressed the individual issues above. Let me know if you have any further questions/comments? Thanks! |
|
@skirtles-code @rahaug @hootlex the audio patches mentioned in the individual comments above have been uploaded and are live on the site. Thanks! |
|
@skirtles-code I have created an alternate PR with all the lessons discussed that have no more blockers. what do you think of merging without the dynamic css classes video for now? |
This PR adds Vue School links to the documentation to supplement the documentation with free training videos.
The lessons are up-to-date, V3 versions of previously approved Vue 2 lessons that were added to the documentation in PR 2379. As requested in PR 311
Screenshots of the placements can be seen here
Lessons
Class Binding
Event Handling
Computed Properties
Conditional Rendering
List Rendering
Methods
Form Input
Vue Devtools