Skip to content

Vueschool links #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Vueschool links #311

wants to merge 19 commits into from

Conversation

rahaug
Copy link
Contributor

@rahaug rahaug commented Jul 21, 2020

This PR adds the approved Vue School links that were added to the Vue 2 documentation in PR 2379.

I've made no changes to the links, they are identical to the Vue 2 version. Screenshots of the placements can be seen here

Lessons
Computed Properties
Reusable Components with Props
Conditional Rendering
List Rendering
Communication between Components with Custom Events

@bencodezen bencodezen linked an issue Jul 21, 2020 that may be closed by this pull request
@bencodezen bencodezen added the release-candidate Issues that will not be addressed until we are ready for RC label Jul 21, 2020
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rahaug! I know you mentioned in your PR that these are equivalent to the lessons found in the v2 docs. Since these docs are for v3, I'm thinking it may make more sense to wait until the Vue 3 course for Vue School is out? The reason I mention this is that the v2 site is not going anywhere, so all of the current links for Vue School will still be on there.

@rahaug
Copy link
Contributor Author

rahaug commented Sep 18, 2020

Hi @bencodezen !

Since there are no changes to how we work with computed properties, props, conditional rendering, list rendering, and custom events from Vue 2 to Vue 3, I think it's beneficial and complementary to add the links to the Vue 3 docs as well.

Users might land on the v3 docs from a search and miss out on visual learning aids.

What do you think?

@rahaug
Copy link
Contributor Author

rahaug commented Jan 5, 2021

The PR is updated with links to free video lessons that were added to the Vue 2 docs in PR 2177.

I've also refactored to use the new VideoLesson component.

Visuals of all links can be seen here

Lessons
Class Binding
Component Registration
Event Handling
Intro to Single File Components
Lifecycle Hooks

Courses
Components Fundamentals

Edit: Added link to Lifecycle Hooks lesson

@bencodezen
Copy link
Member

Thanks for this @rahaug. After reviewing all of the videos, we unfortunately cannot merge this PR. While the concepts are similar from Vue 2 to Vue 3, the code examples and syntax in the lessons reflect an old syntax which would be confusing for users new to the ecosystem.

@bencodezen bencodezen closed this Jan 9, 2021
@rahaug rahaug mentioned this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-candidate Issues that will not be addressed until we are ready for RC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add video courses to docs
3 participants