Skip to content

French translation #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2021
Merged

French translation #955

merged 2 commits into from
Apr 4, 2021

Conversation

demahom18
Copy link
Contributor

@demahom18 demahom18 commented Mar 19, 2021

Add french translation in the community translation table

It is the first time I'm contributing to an open source project, so I don't know if I'm doing it the right way.
I translated almost 60% of the documentation in french.

you can see the deployed site here : https://vue3-fr.netlify.app/
and the repo: github.com/demahom18/docs-next

Add french translation in the community translation table
@skirtles-code
Copy link
Contributor

skirtles-code commented Mar 20, 2021

Thanks for the PR. Great work on the translation.

A few housekeeping bits from me:

  1. Could you enable the Issues tab on the GitHub repo?
  2. Could you delete any unused branches from the repo? I suspect most of those were inherited from the English docs. Sorry about that, we've had a tidy up since you forked.
  3. The sidebar isn't working for the Exemples and Contribuer sections. I believe this is because of lines 155 and 210 in config.js, which shouldn't be translated.
  4. There are some broken link hashes, presumably due to headings being translated. Could you update these please?

Click to view broken links

@demahom18 demahom18 closed this Mar 20, 2021
@demahom18 demahom18 deleted the patch-2 branch March 20, 2021 09:45
@demahom18 demahom18 restored the patch-2 branch March 20, 2021 09:45
@demahom18 demahom18 reopened this Mar 20, 2021
@demahom18
Copy link
Contributor Author

I fixed all the issues you mentionned

@skirtles-code
Copy link
Contributor

It seems I missed a link from my list, sorry. The Engagements récurrents link in the main nav is currently linking to /support-vuejs/#engagements-récurrents but it needs to be /support-vuejs/#engagements-recurrents, without the accent. It looks like VuePress doesn't include the accent when it generates the hash.

@demahom18
Copy link
Contributor Author

I fixed it

@skirtles-code
Copy link
Contributor

@haeresis Could I get your thoughts on migrating this to vuejs-fr on GitHub?

I don't think the migration is strictly required prior to adding it to the Community Translations list but it might be easier to migrate it now rather than after it's 'live'.

@skirtles-code
Copy link
Contributor

Merging. Thank you @demahom18!

@skirtles-code skirtles-code merged commit e95dc4c into vuejs:master Apr 4, 2021
@demahom18 demahom18 deleted the patch-2 branch April 6, 2021 19:14
@MachinisteWeb
Copy link

@skirtles-code , sorry for the delay, I was unavailable.

When you say « Could I get your thoughts on migrating this to vuejs-fr on GitHub? », I see no problem with that. Could you send me the way to proceed or document that explains to me what you exactly expect?

I imagine I will need the help of @demahom18?

@MachinisteWeb
Copy link

MachinisteWeb commented Apr 8, 2021

So I do a fork under vuejs-fr Organization, feel free to work from this fork @demahom18 and suggest merge PR from it. I think you know better than me the state of work and how to proceed for translation so feel free to explain more in details stuff under our fork README.md in the same way we have doing it from https://github.com/vuejs-fr/vuejs.org for example.

I also open an issue section and discussion section in the fork to discuss about how proceed if you want some help or organisation with other member to take care of translation.

@demahom18
Copy link
Contributor Author

I don't understand exactly what you mean @haeresis. Do you want me to make a pull request to merge my translation to vuejs-fr
Organisation ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants