Using built-in components with render and :is #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodezen
requested changes
Mar 18, 2021
There was a problem hiding this comment.
Awesome additions @skirtles-code! I left a few comments that I think are worth discussing before merging, but otherwise can't wait to get this out to everyone!
Co-authored-by: Ben Hong <[email protected]>
Co-authored-by: Ben Hong <[email protected]>
Co-authored-by: Ben Hong <[email protected]>
|
@bencodezen Thanks. I've merged all of your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #554.
The built-in components need to be imported to use them with a
renderfunction or<component :is="...">.Despite appearing to be globally registered, they aren't. Instead, the template compiler has special handling to allow them to be used without global registration, allowing for tree-shaking. This makes it not immediately obvious how to use them in other scenarios.