Added keys to examples on List Rendering #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -189,7 +189,7 @@ There are quite a few other directives, each with its own special functionality. | |||
| ```html | |||
| <div id="list-rendering"> | |||
| <ol> | |||
| <li v-for="todo in todos" v-bind:key="todo.text"> | |||
There was a problem hiding this comment.
@skirtles-code after some thinking I agreed with your point and removed this attribute to prevent a cognitive overhad
skirtles-code
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Looks good.
Longer term I'd like to change some of those examples to use the object directly as the key, rather than a property. That seems to work with Vue 3 but I don't believe it's been officially acknowledged as a supported feature, so I don't think we can use it in the docs yet. There's already #698 tracking this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #796, we decided to make keys recommended for all cases. To make this more visible, we add
keyto all the code examples after we explained whatkeyis