Skip to content

feat: migration badges support i18n #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2020
Merged

feat: migration badges support i18n #650

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb91bf
update: migration badges support i18n
veaba Oct 25, 2020
425b9f3
fix: syntax error
veaba Oct 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/.vuepress/components/MigrationBadges.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,25 @@
<script>
const validBadges = ['new', 'breaking', 'removed', 'updated']
const validBadges = {
new: 'new',
breaking: 'breaking',
removed: 'removed',
updated: 'updated'
}

export default {
props: {
badges: {
type: Array,
default: () => [],
validator(value) {
return value.every(badge => validBadges.includes(badge))
return value.every((badge) => Object.keys(validBadges).includes(badge))
}
}
},
data() {
return {
validBadges
}
}
}
</script>
Expand All @@ -21,7 +31,7 @@ export default {
:class="`migration-badge is-${badgeType}`"
:key="`badge-type-${badgeType}`"
>
{{ badgeType }}
{{ validBadges[badgeType] }}
</span>
</div>
</template>
Expand Down