fix: resolve Subscribe button styling problems on Safari and Edge #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beautiful! Thanks for the fix! |
nick-lai
pushed a commit
to nick-lai/docs-next
that referenced
this pull request
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The original problem was reported in #556. On iOS, the Subscribe button was too short and has a gradient background.
There was an attempt at fixing the height in #625 but that has introduced problems in OSX Safari and recent versions of Edge.
iOS - the height has been fixed but the gradient remains:
Safari (same as Edge):
The original fix changed
heighttomin-height. The problem on Safari/Edge is that the button's default height is too large, so amin-heightdoesn't do anything.Proposed Solution
I believe the original problems can both be fixed using
appearance: none.The new problems can then be resolved by undoing #625.
I've tested across various platforms and as far as I can tell the button now has a consistent height and background.