Skip to content

make pinPadding value change reflect in the template #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

Timibadass
Copy link
Contributor

Description of Problem

The 200px in the paragraph is supposed to change depending on the value of pinPadding.

Proposed Solution

Replace 200 in the text with pinPadding so it updates as the value changes.

Additional Information

The *200px* in the paragraph is supposed to change depending on the value of `pinPadding`.
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thanks @Timibadass!

@bencodezen bencodezen merged commit c4b734d into vuejs:master Oct 7, 2020
nick-lai pushed a commit to nick-lai/docs-next that referenced this pull request Dec 2, 2020
* add `pinPadding` to template

The *200px* in the paragraph is supposed to change depending on the value of `pinPadding`.

* add 'px' to `pinPadding`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants