Skip to content

fix: introduction.md: notable-new-features anchor in TOC #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

ErichDonGubler
Copy link
Contributor

@ErichDonGubler ErichDonGubler commented Sep 18, 2020

Description of Problem

The "New Features" TOC link in the Introduction section of the migration guide is broken, because the current name and anchor of the section (New Features and new-features, respectively) does not match the current section name and anchor (Notable New Features and notable-new-features, respectively).

Proposed Solution

Fix the TOC item's title and link to match the new section name and anchor (Notable New Features and notable-new-features, respectively).

Additional Information

The link seems to have been broken with commit 7e55600 (pretty GH view).

The link seems to have been broken with commit
7e55600 ([pretty GH
view][pretty-view]).

[pretty-view]: vuejs@7e55600#diff-c9868b6bf75c863c7384dcf155eb6497R35
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErichDonGubler thank you for fixing this! 🙇🏻‍♀️

@NataliaTepluhina NataliaTepluhina merged commit df70f14 into vuejs:master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants