Skip to content

feature (#201): design iteration #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2020
Merged

feature (#201): design iteration #202

merged 5 commits into from
Jul 17, 2020

Conversation

bencodezen
Copy link
Member

@bencodezen bencodezen commented Jul 17, 2020 •
edited
Loading

yyx990803
yyx990803 requested changes Jul 17, 2020
View reviewed changes
Copy link
Member

@yyx990803 yyx990803 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we include the 500 font weight, I think it'd also be nice to also change font weight for page headers h2~h6 to 500 (but keep h1 600).

sdras
sdras approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@sdras sdras left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! as soon as Evan's comments are addressed we're good to merge :)

@bencodezen
Copy link
Member Author

@yyx990803 I've updated all changes. Gonna go ahead and merge so this can be published, but let me know if you think of anything else and I'll submit another PR!

Thanks for the review @sdras!

yyx990803
yyx990803 approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@yyx990803 yyx990803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed h1 weight to 600. LGTM!

@bencodezen
Copy link
Member Author

@yyx990803 Ah rats. Missed that exception clause in your sentence. Thanks for pushing that!

@bencodezen bencodezen merged commit 8e7c6bf into master Jul 17, 2020
@NataliaTepluhina NataliaTepluhina deleted the feature/201-design-iteration branch August 3, 2020 04:42
@skirtles-code skirtles-code mentioned this pull request May 11, 2021
Merged
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
@jCodeLife @veaba
style: fix the italics style for Chinese characters (vuejs#202)
77ec266 
* Update attrs.md

删除重复翻译

* Update props.md

* Update src/guide/components/props.md

Co-authored-by: Godpu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 approved these changes

@sdras sdras sdras approved these changes

@phanan phanan Awaiting requested review from phanan

@NataliaTepluhina NataliaTepluhina Awaiting requested review from NataliaTepluhina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iterate on v3 docs design
3 participants
@bencodezen @yyx990803 @sdras