Skip to content

Fix grammatical errors and introduce app.component() in introduction.md #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 24, 2021
Merged

Conversation

seafoamteal
Copy link

Description of Problem

Line 55

There are two "the"s missing, one before the word 'counter' and another before the word "rendered".

Line 161

There is an unnecessary comma before the word "too". According to Grammarly, the comma is not needed when the word 'too' is used at the end of the sentence.

Line 223

  1. There are two "the"s missing, one before the word "app" and another before the word '"parent's".
  2. The word 'objects' is unnecessarily pluralised.
  3. The word 'App' is capitalized, even though the variable is named app in every code snippet on the page.

The app.component() method is used out of the blue

The docs say that the way to register a component is to create a new variable and add it to the components option of the parent, but the next code snippet uses the app.component() method without any prior introduction.

Line 305

There is a missing "a" before the word "more".

Proposed Solution

Line 55

Added the missing "the"s.

Line 161

Removed the unneeded comma.

Line 223

Added the two "the"s, made "objects" singular and changed the "A" in "App" to lowercase.

Line 242

Added a small code snippet detailing how to use the app.component() method to register a component.

Line 305

Added the missing "a".

Additional Information

In the Flatlogic description, the phrase "how real applications is built" is grammatically incorrect since "applications" is a plural noun but "is" refers to a singular noun. I changed it to "how real applications are built."

In the PrimeVue description, the phrase "look&feel" (which lacked spaces between the words and punctuation) has been changed to "look & feel".
In the Flatlogic description, "Check the admin dashboard templates" has been changed to "Check out the admin dashboard templates."
@vercel
Copy link

vercel bot commented Dec 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vuejs/docs/4mhzVHA9snMSkLmaR9WVpmJ7czxt
✅ Preview: Failed

[Deployment for 3270c23 failed]

Removed all use of the app.component() method from the introduction so as to not confuse readers.
@NataliaTepluhina NataliaTepluhina merged commit dfd86d3 into vuejs:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants