Skip to content

docs: Update key-attribute.md #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2021
Merged

docs: Update key-attribute.md #1045

merged 2 commits into from
May 11, 2021

Conversation

Alex-Sokolov
Copy link
Contributor

Description of Problem

Fix example, because now there is a warning about duplicated keys

skirtles-code
skirtles-code suggested changes May 10, 2021
View reviewed changes
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the first example look good to me but I'm not sure about the second example. Unless I'm missing something I think that second change should be reverted. Thanks.

@Alex-Sokolov
Copy link
Contributor Author

Alex-Sokolov commented May 10, 2021 •
edited
Loading

@skirtles-code reverted the second one

@skirtles-code skirtles-code merged commit 43d1ccf into vuejs:master May 11, 2021
@Alex-Sokolov Alex-Sokolov deleted the patch-3 branch May 11, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@skirtles-code skirtles-code skirtles-code requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-Sokolov @skirtles-code