Skip to content

Include tiny-emitter in events API migration strategy #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuripave opened this issue Sep 18, 2020 · 0 comments · Fixed by #494
Closed

Include tiny-emitter in events API migration strategy #493

yuripave opened this issue Sep 18, 2020 · 0 comments · Fixed by #494

Comments

@yuripave
Copy link
Contributor

yuripave commented Sep 18, 2020

In the migration guide, it suggest using mitt to migrate existing event hubs, but its interface is incompatible with Vue 2 where:

  1. mitt's emit doesn't support variadic arguments that $emits supports
  2. mitt doesn't support $once

I suggest to include tiny-emitter which its interface is fully compatible with Vue 2 $on, $off and $once, and its emit method do support variadic arguments.

@yuripave yuripave changed the title Update events API migration strategy to tiny-emitter Include tiny-emitter in events API migration strategy Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant