Add links for free video content at Vue School #2177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yyx990803 I added screenshots with the placements. |
yyx990803
requested changes
May 30, 2019
src/v2/guide/index.md
Outdated
| @@ -13,6 +13,7 @@ If you’d like to learn more about Vue before diving in, we <a id="modal-player | |||
| If you are an experienced frontend developer and want to know how Vue compares to other libraries/frameworks, check out the [Comparison with Other Frameworks](comparison.html). | |||
|
|
|||
| <div class="vue-mastery"><a href="https://www.vuemastery.com/courses/intro-to-vue-js/vue-instance/" target="_blank" rel="noopener" title="Free Vue.js Course">Watch a free video course on Vue Mastery</a></div> | |||
| <div class="vueschool"><a href="https://vueschool.io/courses/vuejs-fundamentals?friend=vuejs" target="_blank" rel="noopener" title="Free Vue.js Fundamentals Course">Watch a free video course on Vue School</a></div> | |||
There was a problem hiding this comment.
I think it's a bit confusing to the users to have both here. It'd be best to keep it as-is.
There was a problem hiding this comment.
@yyx990803 ahh I understand it might be weird to have two links. What do you think in general of offering users multiple resources?
We could have two links (Vue Mastery and Vue School) in one banner or rotating banners.
There was a problem hiding this comment.
@yyx990803 I have removed the link to unblock the PR 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds links to free courses and lessons. We have handpicked the lessons to make sense on their own to not require the users to have watched previous or following lessons.
Courses:
Vue.js Fundamentals
Components Fundamentals
Lessons:
Form Validation
Lifecycle Hooks
Class Binding
Component Registration
Async Components
Custom Vue Directives
Intro to Single File Components
Here are the visuals for the placements.