Skip to content

fix(runtime-dom): use KeepAlive and CustomElement at same time(#6934) #6966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2022
Merged

fix(runtime-dom): use KeepAlive and CustomElement at same time(#6934) #6966

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1c58de
update
ysy945 Oct 27, 2022
afb75ea
update
ysy945 Oct 27, 2022
31b3afd
Update apiCustomElement.ts
yyx990803 Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/runtime-dom/src/apiCustomElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,11 @@ export class VueElement extends BaseClass {
connectedCallback() {
this._connected = true
if (!this._instance) {
this._resolveDef()
if (this._resolved) {
this._update()
} else {
this._resolveDef()
}
}
}

Expand All @@ -197,9 +201,6 @@ export class VueElement extends BaseClass {
* resolve inner component definition (handle possible async component)
*/
private _resolveDef() {
if (this._resolved) {
return
}
this._resolved = true

// set initial attrs
Expand Down