Skip to content

Conversation

LinusBorg
Copy link
Member

close: #5373

@netlify
Copy link

netlify bot commented Feb 8, 2022

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 3d55f46

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/6202a3cbf0d99a0008d3aa6a

😎 Browse the preview: https://deploy-preview-5378--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Feb 8, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 3d55f46

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/6202a3cba98bb00008bd215c

😎 Browse the preview: https://deploy-preview-5378--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Feb 8, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 3d55f46

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/6202a3cb77f1480007536f2d

😎 Browse the preview: https://deploy-preview-5378--vue-next-template-explorer.netlify.app

@LinusBorg LinusBorg added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: custom elements labels Feb 8, 2022
@LinusBorg
Copy link
Member Author

LinusBorg commented Jun 25, 2022

My current implementation would be a breaking change as it would break camelCase listeners that were added programmatically, for example.

Could we get around this by emitting the event both in camel- and kebap-case?

That could also break something, but I'd consider that to be the most extreme of edge cases.

@yyx990803 yyx990803 force-pushed the linusborg/ce-hyphenate-events-5373 branch from 3d55f46 to b7b934d Compare November 11, 2022 03:57
@yyx990803
Copy link
Member

Could we get around this by emitting the event both in camel- and kebap-case?
That could also break something, but I'd consider that to be the most extreme of edge cases.

I think this is safer than always hyphenating. Technically, I don't think custom elements should expect case conversions for emitted events. But the mismatch between Vue conventions is also a valid issue, so I think emitting both versions is an ok compromise.

@yyx990803 yyx990803 merged commit 0b39e46 into main Nov 11, 2022
@yyx990803 yyx990803 deleted the linusborg/ce-hyphenate-events-5373 branch November 11, 2022 04:01
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: custom elements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event names for Custom Elements should be automatically transformed
4 participants