-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
fix(runtime-vapor): handle prop when vapor renders vdom component #14027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-vapor): handle prop when vapor renders vdom component #14027
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Size ReportBundles
Usages
|
|
duplicate of #13382 |
| export const rawPropsProxyHandlers: ProxyHandler<RawProps> = { | ||
| get: getAttrFromRawProps, | ||
| get(target, key) { | ||
| if (key === ReactiveFlags.RAW) return target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here are too broad. The actual bug scenario is clear and only exists when passing vapor props to createVNode. I think the changes in #13382 would be safer.
Playground