Skip to content

Conversation

edison1105
Copy link
Member

No description provided.

Copy link

coderabbitai bot commented Sep 11, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/vaporHMR

Comment @coderabbitai help to get the list of available commands and usage tips.

@edison1105 edison1105 added version: minor scope: vapor related to vapor mode labels Sep 11, 2025
Copy link

github-actions bot commented Sep 11, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.6 kB 25.9 kB 23.6 kB
createVaporApp 20.9 kB 8.26 kB 7.57 kB
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

Copy link

pkg-pr-new bot commented Sep 11, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13866

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13866

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13866

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13866

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13866

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13866

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13866

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13866

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13866

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13866

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13866

vue

npm i https://pkg.pr.new/vue@13866

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13866

commit: 3f2ff22

@edison1105 edison1105 changed the title fix(hmr): add cleanup call in hmrRerender and update parentInstance.block during reload fix(hmr): update parentInstance.block during hmr reload Sep 11, 2025
@edison1105 edison1105 marked this pull request as ready for review September 11, 2025 07:24
@edison1105 edison1105 changed the title fix(hmr): update parentInstance.block during hmr reload fix(hmr): update old instance.block during hmr reload Sep 12, 2025
@edison1105 edison1105 changed the title fix(hmr): update old instance.block during hmr reload fix(hmr): update old instance during hmr reload Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: vapor related to vapor mode version: minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant