chore(compiler-sfc): match @keyframes exactly

[KazariEX]

Use the same matching rule as the animation property.

Summary by CodeRabbit

• Refactor
  • Improved and unified the detection of CSS keyframes at-rules, resulting in more consistent handling of scoped styles. No changes to visible behavior or public interfaces.

[coderabbitai]

Walkthrough

A new regular expression, keyframesRE, was introduced to centralize and standardize the detection of CSS keyframes at-rules. The code now uses this regex in place of previous inline regex patterns for identifying keyframes, ensuring consistent matching logic throughout the relevant module.

Changes

File	Change Summary
packages/compiler-sfc/src/style/pluginScoped.ts	Replaced inline keyframes regex checks with a centralized keyframesRE for consistent usage.

Poem

In the land of code where styles are scoped,
A regex was born, so keyframes are roped.
No more repeats, just one central rule,
Matching keyframes—oh, regex, you’re cool!
Hopping through styles with pattern in hand,
This bunny ensures your keyframes are grand.
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.4 kB	34.5 kB
vue.global.prod.js	159 kB	58.5 kB	52.1 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.5 kB	18.2 kB	16.7 kB
createApp	54.5 kB	21.2 kB	19.4 kB
createSSRApp	58.7 kB	22.9 kB	20.9 kB
defineCustomElement	59.4 kB	22.8 kB	20.8 kB
overall	68.5 kB	26.4 kB	24 kB

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13566

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13566

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13566

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13566

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13566

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13566

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13566

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13566

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13566

vue

npm i https://pkg.pr.new/vue@13566

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13566

commit: 72077af

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/compiler-sfc/src/style/pluginScoped.ts (1)

11-14: Ensure regex-style consistency across the file

keyframesRE wisely re-uses the same prefix rule that animation(RE|NameRE) use, but note the slight stylistic mismatch:

const animationNameRE = /^(-\w+-)?animation-name$/
const animationRE      = /^(-\w+-)?animation$/
const keyframesRE      = /^(?:-\w+-)?keyframes$/   <-- non-capturing group

For uniformity (and to avoid accidental “eslint-regexp/no-capturing-group” toggle-flopping), consider switching all three to either capturing or non-capturing groups.
Example (non-capturing everywhere):

-const animationNameRE = /^(-\w+-)?animation-name$/
-const animationRE = /^(-\w+-)?animation$/
+const animationNameRE = /^(?:-\w+-)?animation-name$/
+const animationRE = /^(?:-\w+-)?animation$/

Purely cosmetic, but keeps grepping / lint rules predictable.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eca0e1c and 72077af.

📒 Files selected for processing (1)

• packages/compiler-sfc/src/style/pluginScoped.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Redirect rules
• GitHub Check: Header rules
• GitHub Check: Pages changed

🔇 Additional comments (2)

packages/compiler-sfc/src/style/pluginScoped.ts (2)

24-29: 👍 Centralised keyframe detection improves maintainability

Replacing the ad-hoc regex with keyframesRE removes duplication and guarantees one-stop-shop updates if the matching logic ever changes. Implementation looks correct and has no behavioural regressions.

---

70-75: Guard clause now leverages shared regex – good call

Using keyframesRE inside processRule() keeps the skip-logic in sync with the AtRule visitor. Verified that the early-return behaviour is unchanged.