Fixed calling result hook twice when fetching data from cache #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akryum
approved these changes
Dec 17, 2020
|
@Akryum , I really need this change. Could you please share your thoughts about when it will be merged? |
Member
|
I will need to revert this, it's breaking apps using Apollo Client 3. 👀 |
Member
|
Reverted for Apollo Client 3: bda6d96 |
|
@Akryum , will it be somehow fixed? |
Member
|
Sorry but this breaks vue-apollo with Apollo Client 3 so I reverted the change. |
|
I understood. Maybe you have any suggestion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #492
Currently, when the component is fetching data from the cache, the
nextResultmethod is called explicitly byexecuteApollowhenloadingis notfalse. This doesn't involve Apollo Observable subscription and leads to calling queryresulthook twice: once byexecuteApolloand once byobserver.nextThis PR attempts to fix this behaviour