docs: Guide > Best Practices > Production Deployment #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yohei
commented
Mar 20, 2022
| - [Vite deployment guide](https://vitejs.dev/guide/static-deploy.html) | ||
| - [Vue CLI deployment guide](https://cli.vuejs.org/guide/deployment.html) | ||
| - [Vite 本番環境用のビルドガイド](https://ja.vitejs.dev/guide/build.html) | ||
| - [Vite デプロイガイド](https://ja.vitejs.dev/guide/static-deploy.html) |
There was a problem hiding this comment.
[memo]
Vite は日本語の翻訳があったので、リンク先を日本語のものにしました。
jay-es
requested changes
Mar 21, 2022
| ## ビルドツールあり | ||
|
|
||
| Projects scaffolded via `create-vue` (based on Vite) or Vue CLI (based on webpack) are pre-configured for production builds. | ||
| `create-vue` (Vite ベース) または Vue CLI (webpack ベース) で足場が組まれたプロジェクトは、本番ビルド用にあらかじめ設定がされています。 |
There was a problem hiding this comment.
scaffold はそのままだと伝わりにくそうなので「生成」にすると良いかなと思いました
Suggested change
| `create-vue` (Vite ベース) または Vue CLI (webpack ベース) で足場が組まれたプロジェクトは、本番ビルド用にあらかじめ設定がされています。 | |
| `create-vue` (Vite ベース) または Vue CLI (webpack ベース) で生成されたプロジェクトは、本番ビルド用にあらかじめ設定がされています。 |
There was a problem hiding this comment.
レビューありがとうございます、修正しました！
ca53df7
kazupon
reviewed
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #41
よろしくお願いします。