Skip to content

「Tutorial > You Did It!」の翻訳 #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2022
Merged

「Tutorial > You Did It!」の翻訳 #379

merged 2 commits into from
Mar 18, 2022

Conversation

yuri-htt
Copy link

resolve #91

jay-es
jay-es requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@jay-es jay-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしました。
1点修正お願いします:pray:

kazupon
kazupon approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

内容確認しました。
jay-es さん以外の部分以外は特にありませんでした。
そこの修正お願いします。

@jay-es
Update src/tutorial/src/step-15/description.md
6363396 
句点を削除する

Co-authored-by: Jun Shindo <[email protected]>
@yuri-htt yuri-htt requested a review from jay-es March 17, 2022 11:41
@yuri-htt
Copy link
Author

yuri-htt commented Mar 17, 2022 •
edited
Loading

📩 レビュワーさんへ

レビューありがとうございます。
ご丁寧にsuggestをしていただきましたので、その内容に置き換える形でご指摘の1点を修正いたしました。
再度ご確認お願いいたします。

jay-es
jay-es approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@jay-es jay-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます！:pray:

@jay-es jay-es merged commit 8b7929d into vuejs-translations:main Mar 18, 2022
u-sho pushed a commit to u-sho/docs-ja that referenced this pull request Mar 22, 2022
@jay-es @u-sho
「Tutorial > You Did It!」の翻訳 (vuejs-translations#379)
e85ebac 
* translate tutorial/src/step-15/description.md

* Update src/tutorial/src/step-15/description.md

句点を削除する

Co-authored-by: Jun Shindo <[email protected]>

Co-authored-by: Jun Shindo <[email protected]>
u-sho added a commit to u-sho/docs-ja that referenced this pull request Mar 24, 2022
@u-sho
Revert "「Tutorial > You Did It!」の翻訳 (vuejs-translations#379)"
d0af154 
This reverts commit e85ebac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazupon kazupon kazupon approved these changes

@jay-es jay-es jay-es approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

「Tutorial > You Did It!」の翻訳

3 participants

@yuri-htt @kazupon @jay-es