Mapped config.dev.https to devWebpackConfig.devServer (#1217) #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusBorg
reviewed
Jan 9, 2018
| hot: true, | ||
| contentBase: false, // since we use CopyWebpackPlugin. | ||
| compress: true, | ||
| https: config.dev.https, |
Contributor
There was a problem hiding this comment.
Thanks! We still have to add the actual property to /config/index.js file so people can know about the option's existance without studying the webpack files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LinusBorg
The changes are similar as described at #1217, with the addition that in the notification message http|https are show as appropriate.
It took me a while to realize I had to $ vue init bird-cage/webpack #branchName (I'm new to this ;-), but then it worked as expected.
What do you think?
What I also see, but can't figure out how to improve (assuming you would see this as an enhancement) is if for example the port is set in package.json scripts dev: .... --port 8181 the dev server does use this port instead of that in config/index.js, but the notification message still reads ...:8080 or whatever is set in config/index.js