Skip to content

docs: Essentials > List Rendering の翻訳 #8 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2020

Conversation

utano320
Copy link
Contributor

Description of Problem

https://v3.vuejs.org/guide/list.html の翻訳
resolve #8

Proposed Solution

https://github.com/vuejs/jp.vuejs.org/blob/lang-ja/src/v2/guide/list.md
を参考に翻訳

@netlify
Copy link

netlify bot commented Sep 26, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit c11fe58

https://deploy-preview-92--vuejs-v3-ja-doc-preview.netlify.app

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー 👀 コメント 💬 しました。
翻訳ですが、コメントした細かい系以外は、大丈夫です!
レビューコメントの対応お願いします! 🙏

@@ -174,23 +174,23 @@ Vue wraps an observed array's mutation methods so they will also trigger view up
- `sort()`
- `reverse()`

You can open the console and play with the previous examples' `items` array by calling their mutation methods. For example: `example1.items.push({ message: 'Baz' })`.
コンソールを開いて前の `items` 配列の例で変更メソッドを呼び出して遊んでみてください。例えば `example1.items.push({ message: 'Baz' })` のようにしてみましょう。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 ベースだと思いますが、play の訳 遊ぶ はやっぱり違和感があるので、ここでは意訳で 試す にしておいてください。 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました!

@utano320
Copy link
Contributor Author

@kazupon レビューありがとうございます!修正いたしましたので、ご確認よろしくお願いします!

@kazupon
Copy link
Member

kazupon commented Sep 27, 2020

対応ありがとうございました。
確認しました!
CIでエラーが起きていますが、翻訳作業に支障はない(このPRとは別事象)なので、マージします!

翻訳ありがとうございました!

@kazupon kazupon merged commit 26587b0 into vuejs-jp:lang-ja Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Essentials > List Rendering の翻訳
2 participants