Skip to content

docs: Essentials > Event Handling の翻訳 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

entaku0818
Copy link
Contributor

Description of Problem

Essentials > Event Handling の翻訳
https://v3.vuejs.org/guide/events.html

Proposed Solution

https://jp.vuejs.org/v2/guide/events.html
を参考に翻訳

Additional Information

特になし

@netlify
Copy link

netlify bot commented Sep 23, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit 4711aa7

https://deploy-preview-87--vuejs-v3-ja-doc-preview.netlify.app

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー 👀 コメント 💬 しました!
確認お願いします!


## Listening to Events
## イベントの購読
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すいませんが、原文と同じ行構成(タイトルの次に改行入れる)にしてもらえますか? 🙏
公式ドキュメントのメンテの都合上、diff を見やすくしたり、コンフリクトを防ぎたいので。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正します!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazupon
他の部分も改行あうように修正しました!

@kazupon
Copy link
Member

kazupon commented Sep 28, 2020

対応ありがとうございました!
確認しました!
CIでエラーが起きていますが、翻訳作業に支障がない(このPRとは別事象)なので、マージしますね。

翻訳ありがとうございました!

@kazupon kazupon merged commit cb87291 into vuejs-jp:lang-ja Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants