Skip to content

docs: Components In-Depth > Component Registration の翻訳 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HomMarkHunt
Copy link
Collaborator

@HomMarkHunt HomMarkHunt commented Sep 21, 2020

resolve #12

Components In-Depth > Component Registration の翻訳

@netlify
Copy link

netlify bot commented Sep 21, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit b854fa6

https://deploy-preview-75--vuejs-v3-ja-doc-preview.netlify.app


The name you give a component may depend on where you intend to use it. When using a component directly in the DOM (as opposed to in a string template or [single-file component](../guide/single-file-component.html), we strongly recommend following the [W3C rules](https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom-element-name) for custom tag names:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

かなり細かいですが directly in the DOM( の閉じ括弧がつけて忘れているのかな?と判断したので as opposed to in a string template or [single-file component](../guide/single-file-component.html) までを括弧として翻訳しました。勘違いでしたら申し訳ございません。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ、括弧の閉じ忘れですね... (本家へ PR contribution のいい機会ですね!)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

せっかくなので送ってみました
vuejs/docs#568

@HomMarkHunt HomMarkHunt force-pushed the translate-component-registration branch from 7715265 to d0d48b4 Compare September 21, 2020 16:51
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー 👀 コメント 💬 しました。
対応お願いします!


The name you give a component may depend on where you intend to use it. When using a component directly in the DOM (as opposed to in a string template or [single-file component](../guide/single-file-component.html), we strongly recommend following the [W3C rules](https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom-element-name) for custom tag names:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ、括弧の閉じ忘れですね... (本家へ PR contribution のいい機会ですね!)

@@ -146,20 +146,20 @@ export default {
}
```

Note that in ES2015+, placing a variable name like `ComponentA` inside an object is shorthand for `ComponentA: ComponentA`, meaning the name of the variable is both:
ES2015+ の場合、`ComponentA` のような変数名をオブジェクト内に配置することは `ComponentA: ComponentA` の省略記法にあたり、変数の名前は次のどちらも意味することに注意して下さい:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES2015+ES2015 以降 で訳せそうです。

Co-authored-by: kazuya kawaguchi <[email protected]>
@HomMarkHunt HomMarkHunt force-pushed the translate-component-registration branch from b4bd24e to 829e3dd Compare September 29, 2020 11:55
@HomMarkHunt HomMarkHunt requested a review from kazupon September 29, 2020 11:55
@HomMarkHunt
Copy link
Collaborator Author

@kazupon
対応遅くなってしまい申し訳ございません
頂いたレビュー箇所修正いたしましたのでご確認お願いします

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typoだけありますので、よろしくお願いします! 🙏

@HomMarkHunt
Copy link
Collaborator Author

@kazupon
何度も申し訳ございません🙏🙏🙏
最後のtypoも修正いたしました🙏🙏🙏

@kazupon
Copy link
Member

kazupon commented Sep 30, 2020

対応ありがとうございました!
確認しました。
CIでエラーが起きていますが、翻訳作業に支障はない(このPRとは別事象)ので、マージしますね。

翻訳ありがとうございました!

@kazupon kazupon merged commit eb72d4f into vuejs-jp:lang-ja Sep 30, 2020
@HomMarkHunt HomMarkHunt deleted the translate-component-registration branch September 30, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components In-Depth > Component Registration の翻訳
2 participants