Skip to content

docs: #10 Essentials > Form Input Bindings の翻訳 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Masa-Shin
Copy link
Collaborator

resolve #10

@netlify
Copy link

netlify bot commented Sep 19, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit 97708ec

https://deploy-preview-63--vuejs-v3-ja-doc-preview.netlify.app

@Masa-Shin Masa-Shin force-pushed the issue-10-translate-form-input-binding branch 2 times, most recently from 9e3a947 to 1d0097a Compare September 19, 2020 10:56
@Masa-Shin Masa-Shin force-pushed the issue-10-translate-form-input-binding branch from 1d0097a to 138d5df Compare September 19, 2020 12:29
@Masa-Shin
Copy link
Collaborator Author

こちらCIが通らないのですが、コード以外の問題(アクセス権限?)のような気がします。

参考

@Masa-Shin
Copy link
Collaborator Author

#1 (comment) に関しては、他のPRでは訳していたり訳していなかったりだったので、今回は一旦訳出しない形にしました。

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳ありがとうございます!
レビューコメントしました!
対応お願いします!


Single checkbox, boolean value:
単一のチェックボックスと boolean 値:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいですが、 は半角の : でお願いします。
以降も、いくつかありますので、よろしくお願いします 🙏

@kazupon
Copy link
Member

kazupon commented Sep 20, 2020

GitHub Actoins のエラーは、現状特に支障はないので、一旦無視でお願いします!

@Masa-Shin
Copy link
Collaborator Author

@kazupon
ありがとうございます!
セミコロンを修正しました。

@kazupon
Copy link
Member

kazupon commented Sep 21, 2020

@Masa-Shin
ありがとうございます!確認しました!
マージします!

@kazupon kazupon merged commit 3ae53bb into vuejs-jp:lang-ja Sep 21, 2020
@kazupon
Copy link
Member

kazupon commented Sep 21, 2020

翻訳ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Essentials > Form Input Bindings の翻訳
2 participants