Skip to content

サイドバーのメニューを更新 #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2021
Merged

サイドバーのメニューを更新 #252

merged 3 commits into from
Apr 15, 2021

Conversation

naokie
Copy link
Member

@naokie naokie commented Apr 14, 2021

Description of Problem

#201 を進めるにあたって、ナビゲーションの不一致で公式ドキュメントと日本語訳ドキュメントが比較がしづらい。

Proposed Solution

公式の Vue Press 設定に追従しつつ、次の2点をコメントアウトで除いておきます。

  • 日本語訳ファイルがまだなく 404 エラーになるもの
  • PWA 対応など、公式に取り込まれているが、日本語ドキュメントではまだ取り込んでいないもの

Additional Information

公式に追いついたものから、コメントアウトを取り除いて公開していければなと。

#248, #250, #251 とはコンフリクトするため、この pull request はそれらすべてマージされてからが望ましいです。

@netlify
Copy link

netlify bot commented Apr 14, 2021

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit a5ace44

https://deploy-preview-252--vuejs-v3-ja-doc-preview.netlify.app

…config

* upstream/lang-ja:
  Migration > v-on-native-modifier-removed の翻訳を追従 (#251)
  Migration > Watch の翻訳を追従 (#250)
  Migration > Listeners Removed の翻訳を追従 (#248)
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

了解です!これでいきましょう!

@kazupon kazupon merged commit 41c2578 into vuejs-jp:lang-ja Apr 15, 2021
@naokie naokie deleted the feature/sidebar-config branch April 16, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants