Skip to content

Migration Guide > Custom Directives の翻訳元ファイル更新と翻訳 #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

daisuke85a
Copy link
Contributor

@potato4d @egurinko

resolve #110

https://v3.vuejs.org/guide/migration/custom-directives.html の内容を翻訳しました!

翻訳前ファイルが古かったので、 https://github.com/vuejs/docs-next/blob/master/src/guide/migration/custom-directives.md から最新版をとってきて、それに対して翻訳しました。

ご確認をよろしくおねがいします!

@netlify
Copy link

netlify bot commented Nov 8, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit 61bd806

https://deploy-preview-161--vuejs-v3-ja-doc-preview.netlify.app

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいところ少しだけ良い感じにしてもらえればと思います。

全体、LGTMです!

resolve vuejs-jp#110

レビュー指摘対応
- also が訳抜けしていたので該当箇所を追記
- 読みやすくなるよう修正
@daisuke85a
Copy link
Contributor Author

@potato4d
ご確認とご指摘をありがとうございます!
2つの指摘とも、ご提案どおり修正しました。読みやすくなりました!ありがとうございます!

お手数ですが、再度ご確認をお願いいたします🙏

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
ありがとうございま下ー!

@potato4d potato4d merged commit 2b8a958 into vuejs-jp:lang-ja Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration Guide > Custom Directives の翻訳
2 participants