Skip to content

Migration Guide > Slots Unification の翻訳 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Katakuranatsumi
Copy link
Contributor

resolve #124

https://v3.vuejs.org/guide/migration/slots-unification.html を翻訳しましたmm
レビューをお願いいたします🙏

@Katakuranatsumi Katakuranatsumi marked this pull request as draft October 25, 2020 14:07
@netlify
Copy link

netlify bot commented Oct 25, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit 9eb594e

https://deploy-preview-146--vuejs-v3-ja-doc-preview.netlify.app

@Katakuranatsumi Katakuranatsumi marked this pull request as ready for review October 25, 2020 14:10
@netlify
Copy link

netlify bot commented Oct 25, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit 31c41f6

https://deploy-preview-146--vuejs-v3-ja-doc-preview.netlify.app

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳ありがとうございます!

一点だけ修正お願いします。

- `this.$slots` now exposes slots as functions
- **BREAKING**: `this.$scopedSlots` is removed
- `this.$slots` はスロットを関数として公開するようになりました
- **速報**: `this.$scopedSlots` が削除されました
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この Breaking は Breaking Changes つまりは破壊的変更を意味しているので、そちらで訳していただきたいです!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potato4d
ご確認ありがとうございましたmm
こちら 31c41f6 で修正しました🙇‍♀️

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@potato4d potato4d merged commit 93a3a0e into vuejs-jp:lang-ja Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration Guide > Slots Unification の翻訳
2 participants