Skip to content

fix: useWave unref #7108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tangjinzhou merged 4 commits into from
Dec 18, 2023
Merged

fix: useWave unref #7108

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e303f83
fix: useWave unref
Nov 13, 2023
57df414
fix: wave init value
puppet-666 Nov 14, 2023
8f69d77
fix: wave value
puppet-666 Nov 14, 2023
2f2ac85
Update useConfigInject.ts
tangjinzhou Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/_util/wave/useWave.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ import showWaveEffect from './WaveEffect';
export default function useWave(
instance: ComponentInternalInstance | null,
className: Ref<string>,
wave: ComputedRef<{ disabled?: boolean }>,
wave?: ComputedRef<{ disabled?: boolean }>,
): VoidFunction {
function showWave() {
const node = findDOMNode(instance);

if (wave.value?.disabled || !node) {
if (wave?.value?.disabled || !node) {
return;
}

Expand Down