Skip to content

Conversation

webfansplz
Copy link
Member

1111.mov

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for vue-termui ready!

Name Link
🔨 Latest commit 4997d1a
🔍 Latest deploy log https://app.netlify.com/sites/vue-termui/deploys/637206b189a81f0008a926dd
😎 Deploy Preview https://deploy-preview-15--vue-termui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@webfansplz webfansplz requested a review from posva October 31, 2022 13:29
Copy link
Collaborator

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should be very different. Right now it really looks like https://github.com/terkelg/prompts but we have the opportunity of making something much more interactive that can be focused and unfocused at any time

@webfansplz webfansplz marked this pull request as draft November 14, 2022 08:43
@webfansplz webfansplz marked this pull request as ready for review November 14, 2022 08:52
@webfansplz webfansplz marked this pull request as draft November 14, 2022 08:53
@webfansplz webfansplz marked this pull request as ready for review November 14, 2022 09:05
@codecov-commenter
Copy link

Codecov Report

Base: 64.76% // Head: 64.64% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (4997d1a) compared to base (7fa3801).
Patch coverage: 8.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   64.76%   64.64%   -0.12%     
==========================================
  Files          44       44              
  Lines        4129     4135       +6     
  Branches      195      195              
==========================================
- Hits         2674     2673       -1     
- Misses       1455     1461       +6     
- Partials        0        1       +1     
Impacted Files Coverage Δ
packages/core/src/composables/utils.ts 46.51% <0.00%> (-9.05%) ⬇️
packages/core/src/focus/Focusable.ts 37.50% <ø> (-0.71%) ⬇️
packages/core/src/components/index.ts 100.00% <100.00%> (ø)
packages/core/src/renderer/render.ts 72.72% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@webfansplz webfansplz requested a review from posva November 14, 2022 09:21
@posva
Copy link
Collaborator

posva commented Nov 15, 2022

I didn't check if having a vue file supposes any problem when it comes to using the component in an external project. Compiling the .vue components is in general a good idea because they end up being more performant than plain js

@webfansplz webfansplz merged commit b720d15 into vue-terminal:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants