Fixes allOf bug when using noAdditionalProperties option
#535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 76 76
Lines 1562 1562
=======================================
Hits 1414 1414
Misses 148 148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @azrosen92 , thanks for the test! Are you able to provide a fix for it? |
|
@bastelfreak just getting back from vacation – I'd like to try to work on a fix, I'll aim to have something in the next week or two! |
azrosen92
force-pushed
the
no-additional-properties-incompatible-with-all-of
branch
from
1fa33a0 to
f18f13e
Compare
|
@bastelfreak I think this is ready for a review. Please let me know if you have any questions/concerns! |
azrosen92
changed the title
allOf bug when using noAdditionalProperties option
|
@hoxworth – would love to get some eyes on this ASAP 🙇🏻♂️ |
|
@azrosen92 thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug when evaluating additional properties in
allOfsubschemas.When using the
noAdditionalPropertiesoption, json-schema incorrectly evaluatesallOfschemas by marking json data invalid before having evaluated it against all of the sub schemas within anallOfschema. In the logic implemented in the properties attribute class to handle thenoAdditionalPropertiesoption, json-schema correctly identifies any additional properties that are not defined in that schema. However, if the parent schema isallOfand one of the other sub shemas within thatallOfdoes expect that attribute, then these additional properties may in fact be valid. Therefore, we must look at all of the errors from all sub schemas within thatallOfin order to be able to properly determine whether there is an additional property that has not been defined in any of those sub schemas.This PR does 2 things to accomplish this
propertiesattribute toValidationErrorallowing us to record the additional properties detected within the dataAllOfAttributeclass to consider whether there are any additional properties that were detected across all sub schemas of theallOf.