-
Notifications
You must be signed in to change notification settings - Fork 2.4k
ergo: update to 2.11.1, rename from oragono. #34581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry, commented before I was done thinking :)
|
Actually, you should follow what was done for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pbui ok for you?
Yes, these changes look reasonable. As a side note, you can probably remove me from the maintainer field... as I don't use Void Linux anymore and probably will not be contributing updates for the foreseeable future. |
a19bd3e
to
62d2307
Compare
fd3048a
to
9b84f2e
Compare
Please move data files in |
@sgn I'm sorry but I'm not sure what you want me to do concretely with which exact folder |
I meant move files from |
@sgn I actually wanted to do that conditionally but couldn't figure out whether there was an appropriate way to do it or not, so any ideas would be greatly appreciated |
What would be the condition? Do you mean that you would want existing installations to keep using the old location, but new ones to use the ergo location? We don't have a good way to do this. |
In my opinion, at least keychain should be kept. |
@paper42 I more meant as a specific way of doing a one-time rename of the directory when updating it |
Would something like the |
applied onto 3a4b215, it currently
|
Issue is I can't reproduce it for the moment and seems apparently neither can the CI, but is it related to this? golang/go#43505 |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
a555e89
to
434d5f8
Compare
4abe67b
to
3535d30
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
...? |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
@classabbyamp could this be re-opened? To the best of my knowledge this PR still works just fine and is simply waiting to be merged for a very long time |
apparently not... make a new pr please an link this one. I've been meaning to look at this but it's fairly complex so hard to find the time |
Note: I couldn't find out what was the procedure for updating packages where they get renamed, I did what I thought wasn't stupid, please feel free to tell me if I screwed anything up with it 😅
Testing the changes
Local build testing