Skip to content

ergo: update to 2.11.1, rename from oragono. #34581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chilledfrogs
Copy link
Contributor

Note: I couldn't find out what was the procedure for updating packages where they get renamed, I did what I thought wasn't stupid, please feel free to tell me if I screwed anything up with it 😅

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64

@TinfoilSubmarine
Copy link
Contributor

TinfoilSubmarine commented Dec 17, 2021

Sorry, commented before I was done thinking :)

You already have the symlink, but I think the provides=... and replaces=... should be similar to what mysql/mariadb has since this is just a rename, as well as an oragano_package() similar to mysql_package().

@TinfoilSubmarine
Copy link
Contributor

Actually, you should follow what was done for pulseeffects being renamed to easyeffects, since that was more recent and was just a rename unlike the mysql/mariadb drop-in case.

@chilledfrogs chilledfrogs changed the title ergo: update to 2.8.0, rename from oragono ergo: update to 2.8.0, rename from oragono. Dec 18, 2021
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbui ok for you?

@pbui
Copy link
Contributor

pbui commented Dec 19, 2021

@pbui ok for you?

Yes, these changes look reasonable.

As a side note, you can probably remove me from the maintainer field... as I don't use Void Linux anymore and probably will not be contributing updates for the foreseeable future.

@chilledfrogs chilledfrogs force-pushed the ergo branch 2 times, most recently from a19bd3e to 62d2307 Compare December 19, 2021 21:09
@chilledfrogs chilledfrogs changed the title ergo: update to 2.8.0, rename from oragono. ergo: update to 2.9.1, rename from oragono. Jan 14, 2022
@sgn
Copy link
Member

sgn commented Jun 24, 2022

Please move data files in /var to new location if we choose to rename its folder.

@chilledfrogs
Copy link
Contributor Author

@sgn I'm sorry but I'm not sure what you want me to do concretely with which exact folder

@sgn
Copy link
Member

sgn commented Jun 30, 2022

@sgn I'm sorry but I'm not sure what you want me to do concretely with which exact folder

I meant move files from /var/lib/oragono to /var/lib/ergo

@chilledfrogs
Copy link
Contributor Author

@sgn I actually wanted to do that conditionally but couldn't figure out whether there was an appropriate way to do it or not, so any ideas would be greatly appreciated

@paper42
Copy link
Member

paper42 commented Jul 3, 2022

@sgn I actually wanted to do that conditionally but couldn't figure out whether there was an appropriate way to do it or not, so any ideas would be greatly appreciated

What would be the condition? Do you mean that you would want existing installations to keep using the old location, but new ones to use the ergo location? We don't have a good way to do this.

@sgn
Copy link
Member

sgn commented Jul 3, 2022

In my opinion, at least keychain should be kept.

@chilledfrogs
Copy link
Contributor Author

@paper42 I more meant as a specific way of doing a one-time rename of the directory when updating it

@chilledfrogs chilledfrogs changed the title ergo: update to 2.9.1, rename from oragono. ergo: update to 2.10.0, rename from oragono. Aug 3, 2022
@chilledfrogs
Copy link
Contributor Author

chilledfrogs commented Aug 3, 2022

Would something like the oragono.INSTALL I added be appropriate?

Piraty added a commit to Piraty/void-packages that referenced this pull request Oct 2, 2022
@Piraty
Copy link
Member

Piraty commented Oct 2, 2022

applied onto 3a4b215, it currently FBTFS FTBFS .

_cgo_callers: relocation target x_cgo_callers not defined
_cgo_init: relocation target x_cgo_init not defined
_cgo_mmap: relocation target x_cgo_mmap not defined
_cgo_munmap: relocation target x_cgo_munmap not defined
/usr/lib/go/pkg/tool/linux_amd64/link: too many errors
=> ERROR: ergo-2.10.0_1: do_build: 'go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}' exited with 2
=> ERROR:   in do_build() at common/build-style/go.sh:43

pkg:ergo host:x86_64-musl target:armv7l-musl cross:y result:FAILED

@chilledfrogs
Copy link
Contributor Author

chilledfrogs commented Oct 3, 2022

_cgo_callers: relocation target x_cgo_callers not defined
_cgo_init: relocation target x_cgo_init not defined
_cgo_mmap: relocation target x_cgo_mmap not defined
_cgo_munmap: relocation target x_cgo_munmap not defined
/usr/lib/go/pkg/tool/linux_amd64/link: too many errors
=> ERROR: ergo-2.10.0_1: do_build: 'go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}' exited with 2
=> ERROR:   in do_build() at common/build-style/go.sh:43

Issue is I can't reproduce it for the moment and seems apparently neither can the CI, but is it related to this? golang/go#43505

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jan 9, 2023
@chilledfrogs chilledfrogs force-pushed the ergo branch 2 times, most recently from a555e89 to 434d5f8 Compare January 23, 2023 22:24
@chilledfrogs chilledfrogs changed the title ergo: update to 2.10.0, rename from oragono. ergo: update to 2.11.1, rename from oragono. Jan 23, 2023
@chilledfrogs chilledfrogs force-pushed the ergo branch 2 times, most recently from 4abe67b to 3535d30 Compare January 23, 2023 22:36
@github-actions github-actions bot removed the Stale label Jan 24, 2023
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 12, 2023
@chilledfrogs
Copy link
Contributor Author

...?

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Aug 12, 2023
@github-actions github-actions bot closed this Aug 26, 2023
@chilledfrogs
Copy link
Contributor Author

@classabbyamp could this be re-opened? To the best of my knowledge this PR still works just fine and is simply waiting to be merged for a very long time

@classabbyamp
Copy link
Member

apparently not... make a new pr please an link this one. I've been meaning to look at this but it's fairly complex so hard to find the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants