Skip to content

Conversation

@abdeoliveira
Copy link
Contributor

@abdeoliveira abdeoliveira commented Dec 4, 2022

Standardize mirror entries. Added a Region column.

@abdeoliveira
Copy link
Contributor Author

I can't see what's wrong with it. I tried to fix it for hours...

@classabbyamp
Copy link
Member

run vmdfmt -w src/

@classabbyamp
Copy link
Member

I don't think this list should have flags in it, flags are (whether we like it or not) sometimes unintentional political statements and that's not something that we should need to worry about in the handbook.

I also don't think using geoip is a good idea, the granularity of location was given by the mirror operator and the geoip may not always be correct (I used to have a public IP that was wrong by hundreds of km)

@abdeoliveira
Copy link
Contributor Author

Ok. So it is probably better I close this PR?

@classabbyamp
Copy link
Member

the other changes were fine

@abdeoliveira abdeoliveira changed the title xbps/repositories/mirrors: standardize + flags xbps/repositories/mirrors: standardize entries Dec 4, 2022
@abdeoliveira
Copy link
Contributor Author

abdeoliveira commented Dec 7, 2022

Should I include the mirror from PR #730?

Copy link
Member

@sgn sgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep those columns aligned, use spaces for alignment please.

@abdeoliveira
Copy link
Contributor Author

abdeoliveira commented Dec 7, 2022

  1. I have included now the mirror described in PR xbps/repositories/mirrors: add void.chililinux.com/voidlinux/ #730
  2. I messed with one file (src/config/media/sndio.md) which was not part of my PR. A wrong commit somewhere. Sorry about that. I'm not a programmer and git is too complicated to my cognitive capabilities. I was afraid to try solving this on my own and messing things even more.
  3. Kept lines in place with SPACE as requested.

@abdeoliveira abdeoliveira requested review from classabbyamp and sgn and removed request for sgn December 7, 2022 13:00
@classabbyamp
Copy link
Member

I messed with one file (src/config/media/sndio.md) which was not part of my PR. A wrong commit somewhere

just git checkout HEAD~1 -- src/config/media/sndio.md and amend/force-push

@abdeoliveira abdeoliveira changed the title xbps/repositories/mirrors: standardize entries xbps/repositories/mirrors/index.md: update Dec 7, 2022
@abdeoliveira abdeoliveira requested review from sgn and removed request for classabbyamp December 7, 2022 18:39
@classabbyamp
Copy link
Member

please rebase on master (git pull --rebase upstream master) and make the commit message just xbps/repositories/mirrors: standardize entries (git commit --amend)

@abdeoliveira abdeoliveira changed the title xbps/repositories/mirrors/index.md: update xbps/repositories/mirrors/index.md: standardize entries Dec 9, 2022
@abdeoliveira
Copy link
Contributor Author

abdeoliveira commented Dec 9, 2022

Maybe this PR could be an opportunity to remove mirror entries which are probably dead. Not sure how Void admins treat cases like this.

Based on current/ folder date I may have spotted 4 abandoned mirrors as follows:

  1. https://mirror.puzzle.ch/voidlinux/ (Bern, CH), date: 12 Jun 2021
  2. http://ftp.debian.ru/mirrors/voidlinux/ (Russia), date: 3 Nov 2022
  3. https://mirror.aarnet.edu.au/pub/voidlinux/ (Camberra, AU), date: 27 Nov 2018
  4. https://ftp.swin.edu.au/voidlinux/ (Melbourne, AU), date: 28 nov 2018

@Duncaen
Copy link
Member

Duncaen commented Dec 9, 2022

That dooesn't seem to be reliable if you check the repodata for a update from yesterday:

% curl -s https://mirror.puzzle.ch/voidlinux/current/x86_64-repodata | zstdcat | grep -a "synapse-"
                <string>synapse-1.73.0_1</string>
% curl -s https://ftp.swin.edu.au/voidlinux/current/x86_64-repodata | zstdcat | grep -a "synapse-"
                <string>synapse-1.73.0_1</string>

Also there is https://grafana.s.voidlinux.org/d/cLraC-XMk/mirrors-status?orgId=1&refresh=30s.

Two of them seem to be outdated, the other one is not tracked.

@abdeoliveira
Copy link
Contributor Author

abdeoliveira commented Dec 11, 2022

I see... I will let this subject for you pros.

@abdeoliveira
Copy link
Contributor Author

Please let me know if I'm supposed to do anything else here to get this PR done.

@classabbyamp
Copy link
Member

fix the conflict and it's probably good to go

@abdeoliveira abdeoliveira deleted the tmp branch December 21, 2022 20:06
classabbyamp added a commit to classabbyamp/void-docs that referenced this pull request Dec 23, 2022
the-maldridge pushed a commit that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants