Skip to content

Conversation

tlrmchlsmth
Copy link
Member

While profiling #9856, I found that the calls to time.sleep in shm_broadcast.py were never taking under 50 microseconds, even if RINGBUFFER_SLEEP_INTERVAL is set to 0.

This PR switches to use os.sched_yield() instead.

Using this gist for benchmarking code, os.sched_yield() gives us close to what we wanted, at least on my system.

Benchmarking sleep(1.000000e-07) for 10000 iterations...

Results:
Requested sleep duration: 1.000000e-07s
Mean actual duration:     5.247413e-05s
Std dev:                  2.300718e-06s
Min duration:             8.199364e-06s
Max duration:             6.059092e-05s
Benchmarking os.sched_yield() for 10000 iterations...

Results:
Requested sleep duration: 1.000000e-07s
Mean actual duration:     3.195110e-07s
Std dev:                  1.182954e-07s
Min duration:             2.998859e-07s
Max duration:             1.141988e-05s

Copy link

github-actions bot commented Nov 4, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tlrmchlsmth tlrmchlsmth force-pushed the tms/shm_broadcast_yield branch from 6863795 to 02f6c96 Compare November 4, 2024 15:35
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great finding!

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 4, 2024
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) November 4, 2024 20:37
@tlrmchlsmth tlrmchlsmth merged commit 04bbf38 into vllm-project:main Nov 5, 2024
74 checks passed
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants