-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Bugfix] Fix layer skip logic with bitsandbytes #9887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix layer skip logic with bitsandbytes #9887
Conversation
Signed-off-by: mgoin <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: mgoin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: mgoin <[email protected]> Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: s.kochetkov <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: LeiWang1999 <[email protected]>
Found while debugging why
openbmb/MiniCPM-Llama3-V-2_5-int4
doesn't work in #6932, however this is not the full solution.The current implementation was doing a substring match, which causes
kv_proj
to match withinqkv_proj
. We want to match exact module names between the "dots" in full module names.References for
llm_int8_skip_modules
: