Skip to content

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Oct 31, 2024

Found while debugging why openbmb/MiniCPM-Llama3-V-2_5-int4 doesn't work in #6932, however this is not the full solution.

The current implementation was doing a substring match, which causes kv_proj to match within qkv_proj. We want to match exact module names between the "dots" in full module names.

References for llm_int8_skip_modules:

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: mgoin <[email protected]>
@mgoin mgoin requested a review from Isotr0py October 31, 2024 19:22
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 31, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkLight1337 DarkLight1337 merged commit 37a4947 into vllm-project:main Nov 1, 2024
71 checks passed
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Nov 4, 2024
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
sergeykochetkov pushed a commit to sergeykochetkov/vllm_spec_decoding that referenced this pull request Dec 27, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants