[Frontend]: Add apply_chat_template method and update generate method in LLM class #6936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #6416 (Add apply_chat_template method and update generate method in LLM class)
This PR, which is an implementation of the Issue [Feature]#6416 (Add apply_chat_template method and update generate method in LLM class), introduces a new method, apply_chat_template, to the LLM class and integrates it into the existing generate method. The changes add to the flexibility and functionality of the LLM class by allowing for the application of a chat template to input messages, either returning token IDs or raw text based on the user's requirements.
Key Changes:
Purpose: Applies a chat template to a list of messages, with options to add a generation prompt and choose between tokenized output or raw text.
Parameters:
messages_list: A list of messages to be processed.
add_generation_prompt: A boolean flag to indicate whether to add a generation prompt.
tokenize: A boolean flag to determine the output format (token IDs or raw text).
Output:
I have kept the output type as
Union[Union[List[List[str]], List[str]], Union[List[List[int]],List[int]]]
to facilitate usage of the function outside ofgenerate()
method to fetch text and prompt_ids separately as:new parameter :
messages_list
: I have created this separate fromprompts
variable as general structure ofprompts
is different from what we expect inmessages_list
(as it is a list of dictionary with keys denoting type of prompt, user,system,assistant) . Maybe this could be combined withprompts
and we can add those keys automatically.Integrated apply_chat_template to process prompts into prompt_token_ids when prompt_token_ids is not provided.
This allows the generate method to accept raw text prompts and handle them appropriately, converting them to token IDs if necessary.
So now usage becomes:
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!