-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[Build] Revert triton_kernels requirements #27659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts the addition of the triton_kernels dependency to fix a critical installation issue encountered with uv. While this change correctly addresses the installation problem, it also removes a dependency required for mxfp4 fused moe functionality, as indicated by the removed comment. This will likely break that feature. My review comment highlights this trade-off and suggests that this side effect be documented in the pull request description. For a long-term solution, I've recommended considering making this an optional dependency to avoid breaking the build for users who do not require this specific feature.
|
cc @zyongye |
|
I wonder what is the correct way to add a dependency like this? |
|
Apparently this type of direct URL dependency in a package is forbidden by PyPI for security reason; downloading from an untrusted(non-PyPI, that is) domain must be triggered by the end user, not by a hidden dependency. So the solution would be like building the wheel and uploading to a proper wheel index, I think. |
simon-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wheel installation requires all packages in same registry (PyPI).
Let's vendor the code.
|
unblock buildkite/ci/pr/language-models-test-extended-pooling this pr work great with pooling models |
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
e2e3f16 to
2adf439
Compare
|
@simon-mo This is the previous build-kite run, https://buildkite.com/vllm/ci/builds/36673#019a2e0d-01c0-4071-b17d-d1c66f9efe02 I saw your comment on #27598 (comment) mentioning LoRA and Quantization nightly failures. Maybe it is okay to force-merge this PR ? |
|
Oh this is a revert to unbreak main, happy to force merge |
Signed-off-by: Bhagyashri <[email protected]>
Purpose
Revert part of #27370
Adding this triton_kernels as dependency seems to break wheel installation.
Solve : #27573
Test Plan
Test Result