-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[Bug] Fix shape issue for eplb expert weights #27589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yewentao256 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a minor change to vllm/model_executor/layers/fused_moe/layer.py to exclude parameters from non-expert submodules (e.g., gate/shared) when retrieving expert weights. This change addresses a shape issue encountered when using EPLB with DeepSeek-V2-lite. I have added a high severity review comment to ensure the change is correct.
Signed-off-by: yewentao256 <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Bhagyashri <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Purpose
Fixes @smarterclayton 's issue
vllm serve deepseek-ai/DeepSeek-V2-lite --port=8000 --enable-expert-parallel --enable-eplb --num-redundant-experts=16 --eplb-window-size=100 --eplb-step-interval=100 --eplb-log-balancedness -dp 2We will meet an issue
This PR fixes it
Test
(APIServer pid=1225413) INFO 10-27 09:00:03 [launcher.py:46] Route: /start_profile, Methods: POST (APIServer pid=1225413) INFO 10-27 09:00:03 [launcher.py:46] Route: /stop_profile, Methods: POST (APIServer pid=1225413) INFO 10-27 09:00:03 [launcher.py:46] Route: /metrics, Methods: GET (APIServer pid=1225413) INFO: Started server process [1225413] (APIServer pid=1225413) INFO: Waiting for application startup. (APIServer pid=1225413) INFO: Application startup complete.