Skip to content

Conversation

@FENP
Copy link
Contributor

@FENP FENP commented Oct 13, 2025

Purpose

#24440 brings in the QuTLASS library, and I found a small build issue here.
A FATAL_ERROR will be triggered when using QUTLASS_SRC_DIR to build vllm from source.

if(NOT qutlass_SOURCE_DIR)
message(FATAL_ERROR "[QUTLASS] source directory could not be resolved.")
endif()

This pull request fixes build error when use local qutlass source directory via environment variable.

Test Plan

QUTLASS_SRC_DIR=/path/to/qutlass uv pip install -e .

Test Result

Build on SM90 and everything is ok (qutlass build is skipped).

cc @LopezCastroRoberto @mgoin


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: FENP <[email protected]>
@mergify mergify bot added the ci/build label Oct 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies and fixes a build error that occurs when building with a local QUTLASS_SRC_DIR. The issue is that qutlass_SOURCE_DIR was not being set in this scenario, leading to a fatal error. Your change directly addresses this by setting the variable. I've provided one suggestion to use a more idiomatic FetchContent command, which also solves the issue while improving consistency within the script.

Signed-off-by: FENP <[email protected]>
@LopezCastroRoberto
Copy link
Contributor

LGTM! Thanks for the fix.

@FENP
Copy link
Contributor Author

FENP commented Oct 15, 2025

#26773 was merged to fix the error. Close

@FENP FENP closed this Oct 15, 2025
@FENP FENP deleted the bugfix/qutlass_compile branch October 15, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants