[Core] Remove unused prev_sampled_token_ids_invalid_indices input batch field
#26514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this must have been missed during refactoring of vllm-project#23569 before it was merged. Signed-off-by: Nick Hill <[email protected]>
njhill
requested review from
WoosukKwon,
alexm-redhat,
comaniac,
robertgshaw2-redhat and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to remove the unused prev_sampled_token_ids_invalid_indices field, which is a good cleanup. However, the change as presented in the diff appears to introduce a critical bug by failing to filter out invalid requests from prev_req_id_to_index. This could lead to incorrect behavior in asynchronous scheduling. I've provided a comment with a code suggestion to fix this by applying the necessary filtering. With that change, this PR should be good to merge.
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…atch field (vllm-project#26514) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Dhruvilbhatt
pushed a commit
to Dhruvilbhatt/vllm
that referenced
this pull request
Oct 14, 2025
…atch field (vllm-project#26514) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Dhruvil Bhatt <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…atch field (vllm-project#26514) Signed-off-by: Nick Hill <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…atch field (vllm-project#26514) Signed-off-by: Nick Hill <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…atch field (vllm-project#26514) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…atch field (vllm-project#26514) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: 0xrushi <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…atch field (vllm-project#26514) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: 0xrushi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this must have been missed during refactoring done in #23569 before it was merged.
@benchislett