[BugFix] Fix async scheduling + request preemption #26385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhill
commented
Oct 7, 2025
This is an attempt at a minimally invasive quick fix. I'm working on a better fix which will also address the penalties sampling parameter incompatibility. Signed-off-by: Nick Hill <[email protected]>
njhill
force-pushed
the
fix-async-preempt
branch
from
24457e0 to
4ce9ae4
Compare
WoosukKwon
reviewed
Oct 8, 2025
WoosukKwon
reviewed
Oct 8, 2025
5 tasks
|
@WoosukKwon so I think we can piggy-back on #24926 for the scheduler side of this? Then the remaining changes here would be even smaller... |
|
This pull request has merge conflicts that must be resolved before it can be |
# Conflicts: # vllm/v1/core/sched/output.py
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
|
@WoosukKwon the change becomes even smaller after rebasing on #24926. It includes another simplification I noticed that I've opened a separate PR for: #26508. I will aim to add a test next. |
WoosukKwon
approved these changes
Oct 9, 2025
…c-preempt # Conflicts: # vllm/v1/worker/gpu_model_runner.py
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
njhill
requested review from
alexm-redhat,
comaniac,
robertgshaw2-redhat and
ywang96
as code owners
Signed-off-by: Nick Hill <[email protected]>
njhill
force-pushed
the
fix-async-preempt
branch
from
bee9aa2 to
c3eb64b
Compare
Dhruvilbhatt
pushed a commit
to Dhruvilbhatt/vllm
that referenced
this pull request
Oct 14, 2025
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Dhruvil Bhatt <[email protected]>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: bbartels <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure model runner is refreshed with all request token ids following preemption, so that correct input ids are used.