Skip to content

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Sep 25, 2025

Purpose

Follow-up of #25566 and #9856 (comment)

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: youkaichao <[email protected]>
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 25, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) September 25, 2025 11:50
Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change to info instead?

Copy link
Member Author

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change

@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) September 25, 2025 13:07
@youkaichao youkaichao disabled auto-merge September 25, 2025 13:14
@youkaichao youkaichao merged commit 6c340da into vllm-project:main Sep 25, 2025
9 of 14 checks passed
@youkaichao youkaichao deleted the warning_default branch September 25, 2025 13:15
Zhuul pushed a commit to Zhuul/vllm that referenced this pull request Sep 26, 2025
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants