-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Misc][Metrics] expose requests preemptions in logger #25303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ff93550
3bdd7f4
5ab6dc4
c3f7ed3
a2c21a2
6d949db
b2e5dc1
66b1e08
0de3fac
69a7601
9f092a0
6217239
a271abf
73f2bef
1ffb412
b608cb4
b012cf6
13af566
afc679e
170ba7d
a436358
8e75688
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,11 +72,13 @@ def _reset(self, now): | |
# Tracked stats over current local logging interval. | ||
self.num_prompt_tokens: int = 0 | ||
self.num_generation_tokens: int = 0 | ||
self.num_preempted_reqs: int = 0 | ||
|
||
def _track_iteration_stats(self, iteration_stats: IterationStats): | ||
# Save tracked stats for token counters. | ||
self.num_prompt_tokens += iteration_stats.num_prompt_tokens | ||
self.num_generation_tokens += iteration_stats.num_generation_tokens | ||
self.num_preempted_reqs += iteration_stats.num_preempted_reqs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we seem to already have counter_num_preempted_reqs? can we use that? cc: @markmc There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @yeqcharlotte Good point but currently the counter_num_preempted_reqs is in the PrometheusStatLogger and our predictor use our own loggers. |
||
|
||
def _get_throughput(self, tracked_stats: int, now: float) -> float: | ||
# Compute summary metrics for tracked stats | ||
|
Uh oh!
There was an error while loading. Please reload this page.