Skip to content

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Sep 16, 2025

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Isotr0py <[email protected]>
@mergify mergify bot added the new-model Requests to new models label Sep 16, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several recently removed encoder-decoder models to the _PREVIOUSLY_SUPPORTED_MODELS list. This is a good change as it will provide users with a clear and helpful deprecation message if they attempt to use these models, improving the overall user experience. The implementation is straightforward and correct. I have no major concerns with this change.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 16, 2025 13:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 16, 2025
@vllm-bot vllm-bot merged commit d593cf2 into vllm-project:main Sep 16, 2025
59 of 63 checks passed
@Isotr0py Isotr0py deleted the prev-enc-dec branch September 16, 2025 17:50
@vrdn-23
Copy link
Contributor

vrdn-23 commented Sep 16, 2025

@Isotr0py @DarkLight1337 Does this mean there will be a temporary period of not supporting these models or are these encoder-decoder models not going to supported going forward in vLLM?

Apologies if I missed this, but was there an online discussion that kind of highlighted the reasons for the deprecation of these models?

@DarkLight1337
Copy link
Member

We have decided to drop all encoder-decoder models except for Whisper to avoid code complexity in the model runner. #23300 (comment)

FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-model Requests to new models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants