-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[Misc] Add removed encoder-decoder models to previously supported models list #24961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several recently removed encoder-decoder models to the _PREVIOUSLY_SUPPORTED_MODELS list. This is a good change as it will provide users with a clear and helpful deprecation message if they attempt to use these models, improving the overall user experience. The implementation is straightforward and correct. I have no major concerns with this change.
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@Isotr0py @DarkLight1337 Does this mean there will be a temporary period of not supporting these models or are these encoder-decoder models not going to supported going forward in vLLM? Apologies if I missed this, but was there an online discussion that kind of highlighted the reasons for the deprecation of these models? |
|
We have decided to drop all encoder-decoder models except for Whisper to avoid code complexity in the model runner. #23300 (comment) |
…els list (vllm-project#24961) Signed-off-by: Isotr0py <[email protected]>
…els list (vllm-project#24961) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…els list (vllm-project#24961) Signed-off-by: Isotr0py <[email protected]>
…els list (vllm-project#24961) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.