-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[MISC] Add code owners of vllm/v1 to vllm/v1/core #24928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chen Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the .github/CODEOWNERS
file to add more owners for the /vllm/v1/core
and /tests/v1/core
paths. The goal is to distribute the review load for this critical part of the codebase, as explained in the description. The change is straightforward and correct, improving the project's maintainability. I approve this change.
And @22quinn @houseroad Does |
Maybe @njhill can join the sampler-gang? :) |
@22quinn I mean is this line overridden by the line for |
Yeah, sampler is good for @njhill, @22quinn and me. cc: @heheda12345 |
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: charlifu <[email protected]>
Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
Purpose
As
/vllm/v1/core
overrides/vllm/v1
, only I am tagged for PRs that only touches /vllm/v1/core (e.g., #24926). But I don't have the expertise to review all PRs in this folder, so add more people.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.