Skip to content

Conversation

heheda12345
Copy link
Collaborator

@heheda12345 heheda12345 commented Sep 16, 2025

Purpose

As /vllm/v1/core overrides /vllm/v1, only I am tagged for PRs that only touches /vllm/v1/core (e.g., #24926). But I don't have the expertise to review all PRs in this folder, so add more people.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Chen Zhang <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/CODEOWNERS file to add more owners for the /vllm/v1/core and /tests/v1/core paths. The goal is to distribute the review load for this critical part of the codebase, as explained in the description. The change is straightforward and correct, improving the project's maintainability. I approve this change.

@mergify mergify bot added the ci/build label Sep 16, 2025
@heheda12345
Copy link
Collaborator Author

And @22quinn @houseroad Does /vllm/v1/sample @22quinn @houseroad line work well for you two?

@22quinn
Copy link
Collaborator

22quinn commented Sep 16, 2025

And @22quinn @houseroad Does /vllm/v1/sample @22quinn @houseroad line work well for you two?

Maybe @njhill can join the sampler-gang? :)

@heheda12345
Copy link
Collaborator Author

@22quinn I mean is this line overridden by the line for /vllm/v1?

@houseroad
Copy link
Collaborator

Yeah, sampler is good for @njhill, @22quinn and me. cc: @heheda12345

@heheda12345 heheda12345 enabled auto-merge (squash) September 16, 2025 18:47
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 16, 2025
@heheda12345 heheda12345 merged commit 218454b into vllm-project:main Sep 16, 2025
30 checks passed
@heheda12345 heheda12345 deleted the upd_code_owner branch September 16, 2025 19:07
@22quinn
Copy link
Collaborator

22quinn commented Sep 17, 2025

@22quinn I mean is this line overridden by the line for /vllm/v1?

Now I get what you mean - indeed. Fixing in #25037

FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants