-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Core] Support configuration parsing plugin #24277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Xingyu Liu <[email protected]>
Signed-off-by: Xingyu Liu <[email protected]>
Signed-off-by: Xingyu Liu <[email protected]>
Signed-off-by: Xingyu Liu <[email protected]>
Signed-off-by: Xingyu Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an excellent plugin system for configuration parsers, enhancing vLLM's extensibility. The refactoring of existing logic into distinct parser classes is clean and well-executed. My feedback primarily addresses inconsistencies in terminology within the new API, particularly in logging and error messages. Correcting these instances, where 'model loader' appears to be a remnant from copy-pasting and should be 'config parser', will significantly improve the developer experience for this new feature.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Xingyu Liu <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Xingyu Liu <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Xingyu Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as a first step
Signed-off-by: Xingyu Liu <[email protected]>
Signed-off-by: Xingyu Liu <[email protected]>
Signed-off-by: Xingyu Liu <[email protected]>
Thanks for the PR! Let us know if there's anything we can do on HF's side to make this work simpler; as it turns out to be an issue, we could simplify the configuration serialization on our side so that a parser isn't required. Let us know if useful and we'd be happy to help. |
Signed-off-by: Xingyu Liu <[email protected]>
…into config_registry
@LysandreJik Thank you! I think a parser can't be avoided if a model is not using HF format? |
@charlotte12l has imported this pull request. If you are a Meta employee, you can view this in D82033854. |
@@ -0,0 +1,37 @@ | |||
# SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this directory to "Async Engine, Inputs, Utils, Worker Test" so it's actually being run in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added in #24615
Signed-off-by: Xingyu Liu <[email protected]> Signed-off-by: Xingyu Liu <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Xingyu Liu <[email protected]> Signed-off-by: Xingyu Liu <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Xingyu Liu <[email protected]> Signed-off-by: Xingyu Liu <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: xuebwang-amd <[email protected]>
Purpose
In RLHF use cases, internal customized trainer and checkpoint may be used. In order to support these customization, we also need to inject custom vLLM config parser.
This PR makes it more extensible to allow plugin registration for config parsers.
See details in #23009. This PR aims to support
"Custom configuration plugin system" mentioned in proposal.
Note: this is the first step to split out configuration logics, we will continue work on decouple customized config parser with hf
Example:
Test Plan
python -m pytest tests/transformers_utils/test_config_parser_registry.py
Test Result
passed
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.