Skip to content

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Aug 11, 2025

Adds support for SmolLM3 by:

  • Adding it to the supported models docs
  • Adding an entry in the model registry
  • Adding an entry in the test model registry

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation new-model Requests to new models labels Aug 11, 2025
@hmellor hmellor mentioned this pull request Aug 11, 2025
4 tasks
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 11, 2025 17:43
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 11, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds official support for the SmolLM3 model using the Transformers backend. The changes include updating the documentation to list SmolLM3 as a supported model, adding it to the model registry to enable official support via the generic Transformers wrapper, and including it in the test registry. The changes are straightforward and appear correct. I have no major concerns.

@vllm-bot vllm-bot merged commit 80bb1e8 into vllm-project:main Aug 12, 2025
37 of 43 checks passed
@hmellor hmellor deleted the smollm3 branch August 12, 2025 14:05
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@hmellor hmellor moved this to Done in Transformers backend Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation new-model Requests to new models ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants